chrome/browser/password_manager/chrome_password_manager_client.h - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | components/password_manager/core/browser/login_database.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/chrome_password_manager_client.h

diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h

index 10601511f8cb5f2d58f29ef4ebb4399f142a2f92..a8103beeb305ccd5016df8ccadd7864141f40929 100644

--- a/chrome/browser/password_manager/chrome_password_manager_client.h

+++ b/chrome/browser/password_manager/chrome_password_manager_client.h

@@ -44,6 +44,7 @@ class ChromePasswordManagerClient

virtual bool IsPasswordManagerEnabledForCurrentPage() const override;

virtual bool ShouldFilterAutofillResult(

const autofill::PasswordForm& form) override;

+ virtual std::string GetSyncUsername() const override;

virtual bool IsSyncAccountCredential(

const std::string& username, const std::string& origin) const override;

virtual void AutofillResultsComputed() override;

@@ -61,7 +62,8 @@ class ChromePasswordManagerClient

virtual password_manager::PasswordManagerDriver* GetDriver() override;

virtual base::FieldTrial::Probability GetProbabilityForExperiment(

const std::string& experiment_name) override;

- virtual bool IsPasswordSyncEnabled() override;

+ virtual bool IsPasswordSyncEnabled(

+ password_manager::CustomPassphraseState state) override;

virtual void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;

virtual void LogSavePasswordProgress(const std::string& text) override;

virtual bool IsLoggingActive() const override;