components/password_manager/core/browser/password_store_default.cc - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager_client.h ('K') | « components/password_manager/core/browser/password_store_default.h ('k') | components/password_manager/core/browser/stub_password_manager_client.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default.cc

diff --git a/components/password_manager/core/browser/password_store_default.cc b/components/password_manager/core/browser/password_store_default.cc

index 19a26a51e977beb4f51023a894bacbb16a710fe3..b2147c6a52604fd95800cb67eed578f1ed84c883 100644

--- a/components/password_manager/core/browser/password_store_default.cc

+++ b/components/password_manager/core/browser/password_store_default.cc

@@ -26,9 +26,9 @@ PasswordStoreDefault::PasswordStoreDefault(

PasswordStoreDefault::~PasswordStoreDefault() {

}

-void PasswordStoreDefault::ReportMetricsImpl(const std::string& sync_username) {

+void PasswordStoreDefault::ReportMetricsImpl(PasswordManagerClient* client) {

DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());

- login_db_->ReportMetrics(sync_username);

+ login_db_->ReportMetrics(client);

}

PasswordStoreChangeList PasswordStoreDefault::AddLoginImpl(