components/password_manager/core/browser/password_generation_manager.cc - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_generation_manager.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/login_database.cc ('K') | « components/password_manager/core/browser/login_database.cc ('k') | components/password_manager/core/browser/password_generation_manager_unittest.cc » ('j') | components/password_manager/core/browser/password_manager_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_generation_manager.cc

diff --git a/components/password_manager/core/browser/password_generation_manager.cc b/components/password_manager/core/browser/password_generation_manager.cc

index 75499c8503c8ee95f24c2c6ec0fc267fac819c9d..f422bdd6e31d11fc1fa014cd83edd65ec28f3d52 100644

--- a/components/password_manager/core/browser/password_generation_manager.cc

+++ b/components/password_manager/core/browser/password_generation_manager.cc

@@ -49,7 +49,7 @@ bool PasswordGenerationManager::IsGenerationEnabled() const {

return false;

}

- if (!client_->IsPasswordSyncEnabled()) {

+ if (!client_->IsPasswordSyncEnabled(EXCLUDE_CUSTOM_PASSPHRASE_USERS)) {

DVLOG(2) << "Generation disabled because passwords are not being synced";

jww 2014/10/13 18:25:34 Shouldn't this log message actually be "Generation

Garrett Casto 2014/10/13 20:57:56 Done.

return false;

}