Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index 61f264412f3532532d227e2b2bc769e3214af04c..80de39cd2a571fc2b5f6118383c55dc87b0ee27f 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -44,6 +44,7 @@ class ChromePasswordManagerClient
virtual bool IsPasswordManagerEnabledForCurrentPage() const override;
virtual bool ShouldFilterAutofillResult(
const autofill::PasswordForm& form) override;
+ virtual std::string GetSyncUsername() const override;
virtual bool IsSyncAccountCredential(
const std::string& username, const std::string& origin) const override;
virtual void AutofillResultsComputed() override;
@@ -63,7 +64,8 @@ class ChromePasswordManagerClient
virtual password_manager::PasswordManagerDriver* GetDriver() override;
virtual base::FieldTrial::Probability GetProbabilityForExperiment(
const std::string& experiment_name) override;
- virtual bool IsPasswordSyncEnabled() override;
+ virtual bool IsPasswordSyncEnabled(
+ password_manager::CustomPassphraseState state) override;
virtual void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
virtual void LogSavePasswordProgress(const std::string& text) override;
virtual bool IsLoggingActive() const override;

Powered by Google App Engine
This is Rietveld 408576698