components/password_manager/core/browser/test_password_store.h - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/test_password_store.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/stub_password_manager_client.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/test_password_store.h

diff --git a/components/password_manager/core/browser/test_password_store.h b/components/password_manager/core/browser/test_password_store.h

index f759d488743d34139fa8193ed7eaf116584f6d41..fa523a3ae0983349536dbd712d5cded60ca1ddbc 100644

--- a/components/password_manager/core/browser/test_password_store.h

+++ b/components/password_manager/core/browser/test_password_store.h

@@ -57,7 +57,8 @@ class TestPasswordStore : public PasswordStore {

void WrapModificationTask(ModificationTask task) override;

// Unused portions of PasswordStore interface

- void ReportMetricsImpl(const std::string& sync_username) override {}

+ void ReportMetricsImpl(const std::string& sync_username,

+ bool custom_passphrase_sync_enabled) override {}

PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(

base::Time begin,

base::Time end) override;