components/password_manager/core/browser/password_store_unittest.cc - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_default_unittest.cc ('k') | components/password_manager/core/browser/stub_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc

index e8120241360b4232bbbd41a78d9be87e97258e32..667eb35ebdc5bb1e52a74a2ff8f1045a58506b5d 100644

--- a/components/password_manager/core/browser/password_store_unittest.cc

+++ b/components/password_manager/core/browser/password_store_unittest.cc

@@ -68,7 +68,7 @@ TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {

base::MessageLoopProxy::current(),

login_db_.release()));

- store->Init(syncer::SyncableService::StartSyncFlare(), "");

+ store->Init(syncer::SyncableService::StartSyncFlare());

const time_t cutoff = 1325376000; // 00:00 Jan 1 2012 UTC

// The passwords are all empty because PasswordStoreDefault doesn't store the

@@ -199,9 +199,8 @@ TEST_F(PasswordStoreTest, StartSyncFlare) {

base::MessageLoopProxy::current(),

login_db_.release()));

StartSyncFlareMock mock;

- store->Init(base::Bind(&StartSyncFlareMock::StartSyncFlare,

- base::Unretained(&mock)),

- "");

+ store->Init(

+ base::Bind(&StartSyncFlareMock::StartSyncFlare, base::Unretained(&mock)));

{

PasswordForm form;

EXPECT_CALL(mock, StartSyncFlare(syncer::PASSWORDS));