chrome/browser/password_manager/password_store_mac.h - Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_mac.h

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_factory.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_store_mac.h

diff --git a/chrome/browser/password_manager/password_store_mac.h b/chrome/browser/password_manager/password_store_mac.h

index f539e360c3463b07029861cf9bac27e5fc877c47..ecde48523792c78583a41f5921356ad170765ceb 100644

--- a/chrome/browser/password_manager/password_store_mac.h

+++ b/chrome/browser/password_manager/password_store_mac.h

@@ -37,8 +37,7 @@ class PasswordStoreMac : public password_manager::PasswordStore {

password_manager::LoginDatabase* login_db);

// Initializes |thread_|.

- bool Init(const syncer::SyncableService::StartSyncFlare& flare,

- const std::string& sync_username) override;

+ bool Init(const syncer::SyncableService::StartSyncFlare& flare) override;

// Stops |thread_|.

void Shutdown() override;

@@ -50,7 +49,8 @@ class PasswordStoreMac : public password_manager::PasswordStore {

override;

private:

- void ReportMetricsImpl(const std::string& sync_username) override;

+ void ReportMetricsImpl(const std::string& sync_username,

+ bool custom_passphrase_sync_enabled) override;

password_manager::PasswordStoreChangeList AddLoginImpl(

const autofill::PasswordForm& form) override;

password_manager::PasswordStoreChangeList UpdateLoginImpl(

« no previous file with comments | « chrome/browser/password_manager/password_store_factory.cc ('k') | chrome/browser/password_manager/password_store_mac.cc » ('j') | no next file with comments »