Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7791)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 644053003: [Password Manager] Add UMA stats for custom passphrase users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index f60165313ce646f285a53d350bd21bd34cf4fe3e..42ddc2448e32311b4f5a8b0e616a240fef48224c 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -134,6 +134,10 @@ bool ChromePasswordManagerClient::ShouldFilterAutofillResult(
return false;
}
+std::string ChromePasswordManagerClient::GetSyncUsername() const {
+ return password_manager_sync_metrics::GetSyncUsername(profile_);
+}
+
bool ChromePasswordManagerClient::IsSyncAccountCredential(
const std::string& username, const std::string& origin) const {
return password_manager_sync_metrics::IsSyncAccountCredential(
@@ -237,16 +241,18 @@ ChromePasswordManagerClient::GetProbabilityForExperiment(
return enabled_probability;
}
-bool ChromePasswordManagerClient::IsPasswordSyncEnabled() {
+bool ChromePasswordManagerClient::IsPasswordSyncEnabled(
+ password_manager::CustomPassphraseState state) {
ProfileSyncService* sync_service =
ProfileSyncServiceFactory::GetForProfile(profile_);
- // Don't consider sync enabled if the user has a custom passphrase. See
- // crbug.com/358998 for more details.
- if (sync_service &&
- sync_service->HasSyncSetupCompleted() &&
+ if (sync_service && sync_service->HasSyncSetupCompleted() &&
sync_service->SyncActive() &&
- !sync_service->IsUsingSecondaryPassphrase()) {
- return sync_service->GetActiveDataTypes().Has(syncer::PASSWORDS);
+ sync_service->GetActiveDataTypes().Has(syncer::PASSWORDS)) {
+ if (sync_service->IsUsingSecondaryPassphrase()) {
+ return state == password_manager::ONLY_CUSTOM_PASSPHRASE;
+ } else {
+ return state == password_manager::WITHOUT_CUSTOM_PASSPHRASE;
+ }
}
return false;
}

Powered by Google App Engine
This is Rietveld 408576698