tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 93209b724dee46694d5a3e675ac879e13d7a9ecf..dc00f1eb5187ea785582bb034ab6f216d0a74cd2 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -21769,6 +21769,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.AccountsPerSiteWithCustomPassphrase">
+  <owner>dubroy@chromium.org</owner>

[vabr (Chromium), 2014/10/13 09:24:18]

I would not add Patrick as an owner, since he appears no longer active in the
password manager development. You can consider replacing his e-mail with yours,
or just dropping this line completely.

The same in the other histograms below.

[Garrett Casto, 2014/10/13 20:57:56]

Done.

+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Same as AccountsPerSite except distribution only includes users that are

[vabr (Chromium), 2014/10/13 09:24:18]

If I understood correctly, AccountsPerSite (the original one) now excludes
custom passphrase users. Should that be mentioned in it's description?
Alternatively, if you address my comment above in the code, about having two new
histogram names to replace AccountsPerSite, feel free to ignore this comment.

The same in the other histograms below.

[Garrett Casto, 2014/10/13 20:57:56]

N/A.

+    syncing with custom passphrase encryption.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.ActionsTaken"
     enum="PasswordManagerActionsTaken">
   <obsolete>
@@ -21816,6 +21825,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.BlacklistedSitesWithCustomPassphrase">
+  <owner>dubroy@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Same as BlacklistedSites except distribution only includes users that are
+    syncing with custom passphrase encryption.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.Enabled" enum="BooleanEnabled">
   <owner>dubroy@chromium.org</owner>
   <owner>vabr@chromium.org</owner>
@@ -21960,6 +21978,16 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram
+    name="PasswordManager.TimesGeneratedPasswordUsedWithCustomPassphrase">
+  <owner>dubroy@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Same as TimesGeneratedPasswordUsed except distribution only includes users
+    that are syncing with custom passphrase encryption.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.TimesPasswordUsed">
   <owner>dubroy@chromium.org</owner>
   <owner>vabr@chromium.org</owner>
@@ -21970,6 +21998,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.TimesPasswordUsedWithCustomPassphrase">
+  <owner>dubroy@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Same as TimesPasswordUsed except distribution only includes users that are
+    sycning with custom passphrase encryption.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.TotalAccounts">
   <owner>dubroy@chromium.org</owner>
   <owner>vabr@chromium.org</owner>
@@ -21978,6 +22015,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="PasswordManager.TotalAccountsWithCustomPassphrase">
+  <owner>dubroy@chromium.org</owner>
+  <owner>vabr@chromium.org</owner>
+  <summary>
+    Same as TotalAccounts except distribution only includes users that are
+    syncing with custom passphrase encryption.
+  </summary>
+</histogram>
+
 <histogram name="PasswordManager.UIDismissalReason"
     enum="PasswordManagerUIDismissalReason">
   <owner>mkwst@chromium.org</owner>