Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 644023002: [Mac] Enter should trigger the buttons in the new avatar bubble. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Enter should trigger the buttons in the new avatar bubble. Only space seems to work by default. BUG=415823 Committed: https://crrev.com/9750bbaa9e0b3d0bbe44431216d570ecc789024f Cr-Commit-Position: refs/heads/master@{#299157}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
noms (inactive)
I'm not sure I understand why space is the only key that activates those buttons, ...
6 years, 2 months ago (2014-10-10 18:05:57 UTC) #2
groby-ooo-7-16
Only default buttons respond to return. (And they take return even if they don't have ...
6 years, 2 months ago (2014-10-10 18:14:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/644023002/1
6 years, 2 months ago (2014-10-10 18:25:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-10 19:19:47 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9750bbaa9e0b3d0bbe44431216d570ecc789024f Cr-Commit-Position: refs/heads/master@{#299157}
6 years, 2 months ago (2014-10-10 19:21:02 UTC) #7
noms (inactive)
6 years, 2 months ago (2014-10-17 22:18:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/640593006/ by noms@chromium.org.

The reason for reverting is: This doesn't do what it's supposed to do, and after
more discussions with groby@, Enter is really only used for default buttons on
Mac, not all buttons..

Powered by Google App Engine
This is Rietveld 408576698