Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3727)

Unified Diff: cc/resources/tile_manager.h

Issue 643993005: Remove limit on number of resources in cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/tile_manager.h
diff --git a/cc/resources/tile_manager.h b/cc/resources/tile_manager.h
index 6f579f9fb1c9dde8baa82cd233604482f0e00f5f..6ea9bc90d7a25879b5821de22536ce3f153ba69b 100644
--- a/cc/resources/tile_manager.h
+++ b/cc/resources/tile_manager.h
@@ -188,26 +188,6 @@ class CC_EXPORT TileManager : public RasterizerClient,
void AssignGpuMemoryToTiles(TileVector* tiles_that_need_to_be_rasterized);
private:
- class MemoryUsage {
- public:
- MemoryUsage();
- MemoryUsage(int64 memory_bytes, int resource_count);
-
- static MemoryUsage FromConfig(const gfx::Size& size, ResourceFormat format);
- static MemoryUsage FromTile(const Tile* tile);
-
- MemoryUsage& operator+=(const MemoryUsage& other);
- MemoryUsage& operator-=(const MemoryUsage& other);
- MemoryUsage operator-(const MemoryUsage& other);
-
- bool Exceeds(const MemoryUsage& limit) const;
- int64 memory_bytes() const { return memory_bytes_; }
-
- private:
- int64 memory_bytes_;
- int resource_count_;
- };
-
void OnImageDecodeTaskCompleted(int layer_id,
SkPixelRef* pixel_ref,
bool was_canceled);
@@ -223,15 +203,16 @@ class CC_EXPORT TileManager : public RasterizerClient,
scoped_refptr<RasterTask> CreateRasterTask(Tile* tile);
void RebuildEvictionQueueIfNeeded();
- bool FreeTileResourcesUntilUsageIsWithinLimit(const MemoryUsage& limit,
- MemoryUsage* usage);
+ bool FreeTileResourcesUntilUsageIsWithinLimit(int64 limit, int64* usage);
bool FreeTileResourcesWithLowerPriorityUntilUsageIsWithinLimit(
- const MemoryUsage& limit,
+ int64 limit,
const TilePriority& oother_priority,
- MemoryUsage* usage);
+ int64* usage);
bool TilePriorityViolatesMemoryPolicy(const TilePriority& priority);
bool IsReadyToActivate() const;
void CheckIfReadyToActivate();
+ int64 MemoryUsageFromConfig(const gfx::Size& size, ResourceFormat format);
+ int64 MemoryUsageFromTile(const Tile* tile);
TileManagerClient* client_;
scoped_refptr<base::SequencedTaskRunner> task_runner_;

Powered by Google App Engine
This is Rietveld 408576698