Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 643993004: Prepare for ISO-8859-1 to windows-1252 switch (Closed)

Created:
6 years, 2 months ago by jungshik at Google
Modified:
6 years, 2 months ago
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prepare for ISO-8859-1 to windows-1252 switch The following Blink CL will make 'windows-1252' the canonical name for 'ISO-8859-1', 'US-ASCII' and 'windows-1252'. All three will be treated synonymously per the WHATWG Encoding spec. https://codereview.chromium.org/655083002/ We have some test results with 'ISO-8859-1'. Change them to use windows-1252 and disable them before landing the above Blink CL. For PrefsTabHelperBrowserTest.WebPrefs, I made the test more robust by setting 'windows-1251' (not '1252') as the default charset in the Test Preference file. Once the Blink CL is landed and rolled, we'll re-enable the disabled tests as a part of the following Cr CL: https://codereview.chromium.org/649413002/ , which rolls ICU 52 to the latest revision (the other side of ISO-8859-1 to windows-1252 transition). TBR=jochen,rdsmith,mnissler,jsbell BUG=412053 TEST=browser_tests the following tests (before and after the Blink roll) BrowserEncodingTest.TestEncodingAutoDetect BrowserEncodingTest.TestOverrideEncoding EncodingAliases/BrowserEncodingTest.TestEncodingAliasMapping SavePageBrowserTest.FileNameFromPageTitle SavePageBrowserTest.SaveCompleteHTML PrefsTabHelperBrowserTest.WebPrefs Committed: https://crrev.com/51a1d05292ca2813ef6f74e61c1d5e390e2a4f3f Cr-Commit-Position: refs/heads/master@{#300069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M chrome/browser/browser_encoding_browsertest.cc View 4 chunks +17 lines, -4 lines 0 comments Download
M chrome/browser/download/save_page_browsertest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/profiles/web_prefs/Default/Preferences View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
jungshik at Google
I'll TBR this CL because this is just disabling and changing the expected result in ...
6 years, 2 months ago (2014-10-16 22:16:25 UTC) #2
jsbell
The commit comment is: 'ISO-8859-1', 'US-ASCII' and 'ISO-8859-1' Did you mean to list ISO-8859-1 twice? ...
6 years, 2 months ago (2014-10-16 22:53:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643993004/1
6 years, 2 months ago (2014-10-17 05:36:42 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-17 05:36:44 UTC) #7
jungshik at Google
On 2014/10/16 22:53:24, jsbell wrote: > The commit comment is: > > 'ISO-8859-1', 'US-ASCII' and ...
6 years, 2 months ago (2014-10-17 05:41:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643993004/1
6 years, 2 months ago (2014-10-17 05:43:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-17 06:10:50 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 06:11:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51a1d05292ca2813ef6f74e61c1d5e390e2a4f3f
Cr-Commit-Position: refs/heads/master@{#300069}

Powered by Google App Engine
This is Rietveld 408576698