tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py - Issue 643973002: Add multi-architecture support in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

Issue 643973002: Add multi-architecture support in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot failure Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py ('k') | tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

index 64cf6e3b75f9b297a6554fe386c99796aff2c957..172b888376f478967a17856584ca4bcae4d1e6bb 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py

@@ -32,8 +32,9 @@ class OOMKillerProfiler(profiler.Profiler):

browser_backend, platform_backend, output_path, state)

if not 'mem_consumer_launched' in state:

state['mem_consumer_launched'] = True

+ arch_name = self._browser_backend.adb.device().GetABI()

mem_consumer_path = support_binaries.FindPath(

- os.path.join('apks', 'MemConsumer.apk'), 'android')

+ os.path.join('apks', 'MemConsumer.apk'), arch_name, 'android')

assert mem_consumer_path, ('Could not find memconsumer app. Please build '

'memconsumer target.')

if not self._platform_backend.CanLaunchApplication(