tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py - Issue 643973002: Add multi-architecture support in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

Issue 643973002: Add multi-architecture support in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot failure Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/platform_backend.py ('k') | tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

diff --git a/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py b/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

index d2c87c6b1b83fdf9a06b4c22044e9dda714237ea..29ed3438fa2e25272856ec8b9c6db80b80d12624 100644

--- a/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

+++ b/tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py

@@ -19,7 +19,8 @@ def GetDevicePath(profiler_binary):

@decorators.Cache

def InstallOnDevice(device, profiler_binary):

- host_path = support_binaries.FindPath(profiler_binary, 'android')

+ arch_name = device.GetABI()

+ host_path = support_binaries.FindPath(profiler_binary, arch_name, 'android')

if not host_path:

logging.error('Profiler binary "%s" not found. Could not be installed',

host_path)