tools/telemetry/telemetry/core/bitmap.py - Issue 643973002: Add multi-architecture support in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/bitmap.py

Issue 643973002: Add multi-architecture support in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot failure Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/bitmap.py

diff --git a/tools/telemetry/telemetry/core/bitmap.py b/tools/telemetry/telemetry/core/bitmap.py

index 9acfa19f917e76451ee344c3134d4de6a429b290..f130cc4317207bd7f968c084c6a40b7be59edfeb 100644

--- a/tools/telemetry/telemetry/core/bitmap.py

+++ b/tools/telemetry/telemetry/core/bitmap.py

@@ -123,7 +123,9 @@ class _BitmapTools(object):

def __init__(self, dimensions, pixels):

binary = support_binaries.FindPath(

- 'bitmaptools', platform.GetHostPlatform().GetOSName())

+ 'bitmaptools',

+ platform.GetHostPlatform().GetArchName(),

+ platform.GetHostPlatform().GetOSName())

assert binary, 'You must build bitmaptools first!'

self._popen = subprocess.Popen([binary],