Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: net/base/escape.h

Issue 643963004: Unescape BiDi control chars while parsing data urls (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a browsertest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/escape.h
diff --git a/net/base/escape.h b/net/base/escape.h
index 1915d24418883a2186ffc329733a93bc43938085..c4e505d06c42ef0b259870f40d582fda51a4afeb 100644
--- a/net/base/escape.h
+++ b/net/base/escape.h
@@ -93,6 +93,12 @@ class UnescapeRule {
// URL queries use "+" for space. This flag controls that replacement.
REPLACE_PLUS_WITH_SPACE = 16,
+
+ // Unescapes Bidi characters such as RTL/LTR marks. This should only be used
+ // when parsing data urls, but never be used when displaying the url in
+ // the omnibox. URLs in the omnibox should always escape BiDi control
+ // characters for security reasons.
+ BIDI_CONTROL_CHARS = 32,
};
};

Powered by Google App Engine
This is Rietveld 408576698