Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643933002: Remove Overlay Scrollbar if not scrollable along the axis (Closed)

Created:
6 years, 2 months ago by MuVen
Modified:
6 years, 2 months ago
Reviewers:
enne (OOO)
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, jchaffraix+rendering, rune+blink, sivag
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove Overlay Scrollbar if not scrollable along the axis Remove Overlay Scrollbar if not scrollable along that axis. If the scrollSize along that axis is zero then set scrollbar along that axis to false. This is applicable to Solid-Color scrollbars in Android & Overlay scrollbars in the Aura. BUG=415031 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183641

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : without testexpectations #

Patch Set 5 : added test expectations #

Patch Set 6 : Rebased to TOT #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -68 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/select/listbox-nooverlay-scrollbar.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/select/listbox-nooverlay-scrollbar-expected.html View 2 chunks +6 lines, -8 lines 0 comments Download
M LayoutTests/fast/forms/select/listbox-overlay-scrollbar.html View 1 2 3 2 chunks +17 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/select/listbox-overlay-scrollbar-expected.html View 1 2 3 2 chunks +14 lines, -1 line 0 comments Download
M LayoutTests/fast/scrolling/overlay-scrollbars.html View 1 chunk +4 lines, -2 lines 0 comments Download
M LayoutTests/fast/scrolling/overlay-scrollbars-expected.html View 1 2 3 2 chunks +7 lines, -11 lines 0 comments Download
A + LayoutTests/platform/linux/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 Binary file 0 comments Download
A + LayoutTests/platform/linux/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 1 chunk +1 line, -9 lines 0 comments Download
A + LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 Binary file 0 comments Download
A + LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 1 chunk +1 line, -9 lines 0 comments Download
M LayoutTests/platform/win/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/platform/win/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 1 chunk +1 line, -11 lines 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.png View 1 2 3 4 5 Binary file 0 comments Download
M LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 2 3 4 5 1 chunk +1 line, -11 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 3 1 chunk +8 lines, -3 lines 1 comment Download

Messages

Total messages: 20 (16 generated)
MuVen
Hi Enne, PTAL. https://codereview.chromium.org/588013002/ has been reverted with reason "The reason for reverting is: This ...
6 years, 2 months ago (2014-10-13 15:45:01 UTC) #16
enne (OOO)
lgtm, thanks for the fix!
6 years, 2 months ago (2014-10-13 20:04:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643933002/1620001
6 years, 2 months ago (2014-10-14 04:05:10 UTC) #19
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 04:35:48 UTC) #20
Message was sent while issue was closed. 
Committed patchset #6 (id:1620001) as 183641

Powered by Google App Engine
This is Rietveld 408576698