LayoutTests/fast/multicol/float-avoidance.html - Issue 643923003: Convert fast/multicol/float-avoidance to reftest.

Side by Side Diff: LayoutTests/fast/multicol/float-avoidance.html

Issue 643923003: Convert fast/multicol/float-avoidance to reftest. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/multicol/float-avoidance-expected.html » ('j') | LayoutTests/fast/multicol/float-avoidance-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div style="float:left; width:200px; height:100px; background-color:lime"></div >	1 <!DOCTYPE html>

2 <div style="width:415px; -moz-column-width:200px; -webkit-column-width:200px;	2 <style>

3 text-align:justify; border:10px solid black">	3 .float {
mstensho (USE GERRIT) 2014/10/20 20:35:02 This test is so simple that I have a hard time ant This test is so simple that I have a hard time anticipating what could possibly go wrong (unless someone kills me and specs and implements support for multicol containers that don't establish a BFC). :) So how about keeping text-align:justify and the top margin on the P element, just to have some minor evilness? andersr 2014/10/21 08:58:03 Unless this affects the multicol container's abili Show quoted text On 2014/10/20 20:35:02, mstensho wrote: > This test is so simple that I have a hard time anticipating what could possibly > go wrong (unless someone kills me and specs and implements support for multicol > containers that don't establish a BFC). :) > > So how about keeping text-align:justify and the top margin on the P element, > just to have some minor evilness? Unless this affects the multicol container's ability to avoid floats, I think we should have as little "evilness" as possible. If you think this case is covered by fast/block/float/float-avoidance (for example), we should remove it instead. mstensho (USE GERRIT) 2014/10/21 09:11:42 There's no test for multicol there, but that could Show quoted text On 2014/10/21 08:58:03, andersr wrote: > On 2014/10/20 20:35:02, mstensho wrote: > > This test is so simple that I have a hard time anticipating what could > possibly > > go wrong (unless someone kills me and specs and implements support for > multicol > > containers that don't establish a BFC). :) > > > > So how about keeping text-align:justify and the top margin on the P element, > > just to have some minor evilness? > > Unless this affects the multicol container's ability to avoid floats, I think we > should have as little "evilness" as possible. > > If you think this case is covered by fast/block/float/float-avoidance (for > example), we should remove it instead. There's no test for multicol there, but that could have been useful. Anyway, let's keep it here for now. We can live without the extra evilness.
4 <p>This technology preview of our award winning next generation browser	4 float: left;

5 is a sign of things to come from Mozilla. Powerful yet easy to use. This	5 width: 200px;

6 maintenance release provides a few updates based on user feedback - includi ng	6 height: 100px;

7 changes to the Extension System and icon improvements.	7 background-color: lime;

	8 }

	9 .multicol {

	10 width: 400px;

	11 -webkit-column-width: 200px;

	12 -moz-column-width: 200px;
	mstensho (USE GERRIT) 2014/10/20 20:35:02 You can just drop the -moz- stuff. You can just drop the -moz- stuff. andersr 2014/10/21 08:58:03 Done. Show quoted text On 2014/10/20 20:35:02, mstensho wrote: > You can just drop the -moz- stuff. Done.
	13 -webkit-column-gap: 0;

	14 -moz-column-gap: 0;

	15 border: 10px solid black;

	16 line-height: 20px;

	17 }

	18 </style>

	19 <div class="float">

	20 </div>

	21 <div class="multicol">

	22 First column<br>

	23 First column<br>

	24 First column<br>

	25 First column<br>

	26 First column<br>

	27 Second column<br>

	28 Second column<br>

	29 Second column<br>

	30 Second column<br>

	31 Second column<br>

	32 </div>

OLD	NEW