Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: chrome/renderer/resources/extensions/chrome_web_view.js

Issue 643903005: Swapped the variable names "WebView" and "WebViewInternal" in web_view.js and other files that impo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/chrome_web_view_experimental.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This module implements chrome-specific <webview> API. 5 // This module implements chrome-specific <webview> API.
6 6
7 var ChromeWebView = require('chromeWebViewInternal').ChromeWebView; 7 var ChromeWebView = require('chromeWebViewInternal').ChromeWebView;
8 var CreateEvent = require('webViewEvents').CreateEvent; 8 var CreateEvent = require('webViewEvents').CreateEvent;
9 var EventBindings = require('event_bindings'); 9 var EventBindings = require('event_bindings');
10 var WebViewInternal = require('webView').WebViewInternal; 10 var WebView = require('webView').WebView;
11 11
12 var CHROME_WEB_VIEW_EVENTS = { 12 var CHROME_WEB_VIEW_EVENTS = {
13 'contextmenu': { 13 'contextmenu': {
14 evt: CreateEvent('chromeWebViewInternal.contextmenu'), 14 evt: CreateEvent('chromeWebViewInternal.contextmenu'),
15 cancelable: true, 15 cancelable: true,
16 customHandler: function(handler, event, webViewEvent) { 16 customHandler: function(handler, event, webViewEvent) {
17 handler.webViewInternal.maybeHandleContextMenu(event, webViewEvent); 17 handler.webViewInternal.maybeHandleContextMenu(event, webViewEvent);
18 }, 18 },
19 fields: ['items'] 19 fields: ['items']
20 } 20 }
21 }; 21 };
22 22
23 /** 23 /**
24 * Implemented when the ChromeWebView API is available. 24 * Implemented when the ChromeWebView API is available.
25 * @private 25 * @private
26 */ 26 */
27 WebViewInternal.prototype.maybeGetChromeWebViewEvents = function() { 27 WebView.prototype.maybeGetChromeWebViewEvents = function() {
28 return CHROME_WEB_VIEW_EVENTS; 28 return CHROME_WEB_VIEW_EVENTS;
29 }; 29 };
30 30
31 /** 31 /**
32 * Calls to show contextmenu right away instead of dispatching a 'contextmenu' 32 * Calls to show contextmenu right away instead of dispatching a 'contextmenu'
33 * event. 33 * event.
34 * This will be overridden in chrome_web_view_experimental.js to implement 34 * This will be overridden in chrome_web_view_experimental.js to implement
35 * contextmenu API. 35 * contextmenu API.
36 */ 36 */
37 WebViewInternal.prototype.maybeHandleContextMenu = function(e, webViewEvent) { 37 WebView.prototype.maybeHandleContextMenu = function(e, webViewEvent) {
38 var requestId = e.requestId; 38 var requestId = e.requestId;
39 // Setting |params| = undefined will show the context menu unmodified, hence 39 // Setting |params| = undefined will show the context menu unmodified, hence
40 // the 'contextmenu' API is disabled for stable channel. 40 // the 'contextmenu' API is disabled for stable channel.
41 var params = undefined; 41 var params = undefined;
42 ChromeWebView.showContextMenu(this.guestInstanceId, requestId, params); 42 ChromeWebView.showContextMenu(this.guestInstanceId, requestId, params);
43 }; 43 };
OLDNEW
« no previous file with comments | « no previous file | chrome/renderer/resources/extensions/chrome_web_view_experimental.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698