Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643903003: webtry: Add logserver to serve /tmp/glog. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org, humper
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

webtry: Add logserver to serve /tmp/glog. This setup and runs a logserver, like the one being used by skiaperf, to serve the directory /tmp/glog, so we don't need to ssh into the instance to see the logs of the webtry application. This is a follow up to suggestion made in codereview.chromium.org/655323002. BUG=None R=jcgregorio@google.com Committed: https://skia.googlesource.com/skia/+/25a134d1339bc7693ca96c0d46f64ff9ca52c61b

Patch Set 1 #

Total comments: 2

Patch Set 2 : log_dir #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M experimental/webtry/setup/continue_install.sh View 1 chunk +1 line, -0 lines 0 comments Download
A + experimental/webtry/setup/sys/logserver_init View 1 2 chunks +7 lines, -7 lines 0 comments Download
M experimental/webtry/setup/sys/webtry_monit View 1 chunk +4 lines, -0 lines 0 comments Download
M experimental/webtry/setup/webtry_setup.sh View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
Please, take a look. Let me know if I missed some piece.
6 years, 2 months ago (2014-10-16 13:28:51 UTC) #1
jcgregorio
https://codereview.chromium.org/643903003/diff/1/experimental/webtry/setup/sys/logserver_init File experimental/webtry/setup/sys/logserver_init (right): https://codereview.chromium.org/643903003/diff/1/experimental/webtry/setup/sys/logserver_init#newcode25 experimental/webtry/setup/sys/logserver_init:25: DAEMON_ARGS="" --log_dir=/tmp/glog so logserver puts its own logs in ...
6 years, 2 months ago (2014-10-16 13:36:03 UTC) #2
tfarina
https://codereview.chromium.org/643903003/diff/1/experimental/webtry/setup/sys/logserver_init File experimental/webtry/setup/sys/logserver_init (right): https://codereview.chromium.org/643903003/diff/1/experimental/webtry/setup/sys/logserver_init#newcode25 experimental/webtry/setup/sys/logserver_init:25: DAEMON_ARGS="" On 2014/10/16 13:36:03, jcgregorio wrote: > --log_dir=/tmp/glog > ...
6 years, 2 months ago (2014-10-17 00:19:20 UTC) #3
jcgregorio
On 2014/10/17 00:19:20, tfarina wrote: > https://codereview.chromium.org/643903003/diff/1/experimental/webtry/setup/sys/logserver_init > File experimental/webtry/setup/sys/logserver_init (right): > > https://codereview.chromium.org/643903003/diff/1/experimental/webtry/setup/sys/logserver_init#newcode25 > ...
6 years, 2 months ago (2014-10-17 11:30:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643903003/20001
6 years, 2 months ago (2014-10-17 13:49:51 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 14:36:41 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 25a134d1339bc7693ca96c0d46f64ff9ca52c61b

Powered by Google App Engine
This is Rietveld 408576698