Store [-webkit-]perspective-origin as a LengthPoint.

Store [-webkit-]perspective-origin as a LengthPoint.

Using a LengthPoint for this property makes it possible to use
a converter rather than custom code, and it makes animation
building cleaner too.

The setPerspectiveOrigin[X,Y] are kept because of the corresponding
prefixed properties, but they can be removed eventually.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183600

[andersr, 2014-10-10 12:15:54]

andersr@opera.com changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2014-10-10 15:04:20]

lgtm

https://codereview.chromium.org/643893002/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StyleBuilderConverter.cpp (right):

https://codereview.chromium.org/643893002/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleBuilderConverter.cpp:622: return Length(0,
Percent);
Since we never get here, do we need to bother with this return? convertLength
will return a sane default anyway if we have an unexpected value.

[andersr, 2014-10-13 08:37:42]

On 2014/10/10 15:04:20, Timothy Loh wrote:
> lgtm
> 
>
https://codereview.chromium.org/643893002/diff/1/Source/core/css/resolver/Sty...
> File Source/core/css/resolver/StyleBuilderConverter.cpp (right):
> 
>
https://codereview.chromium.org/643893002/diff/1/Source/core/css/resolver/Sty...
> Source/core/css/resolver/StyleBuilderConverter.cpp:622: return Length(0,
> Percent);
> Since we never get here, do we need to bother with this return? convertLength
> will return a sane default anyway if we have an unexpected value.

Done.

[andersr, 2014-10-13 08:38:00]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 08:38:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643893002/140001

[commit-bot: I haz the power, 2014-10-13 08:38:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 08:38:55]

Failed to apply patch for Source/core/css/CSSProperties.in:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSProperties.in
  Hunk #1 FAILED at 233.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/CSSProperties.in.rej

Patch:       Source/core/css/CSSProperties.in
Index: Source/core/css/CSSProperties.in
diff --git a/Source/core/css/CSSProperties.in b/Source/core/css/CSSProperties.in
index
ed5d4efac074b771ecc9721f7386142ed93cdfda..290a92f9870ff1d6803d91dccf97dd90949ae03c
100644
--- a/Source/core/css/CSSProperties.in
+++ b/Source/core/css/CSSProperties.in
@@ -233,7 +233,7 @@ page-break-before type_name=EPageBreak,
initial=initialPageBreak
 page-break-inside type_name=EPageBreak, initial=initialPageBreak
 paint-order inherited, svg, converter=convertPaintOrder
 perspective animatable, converter=convertPerspective
-perspective-origin animatable, custom_all
+perspective-origin animatable, converter=convertPerspectiveOrigin
 pointer-events inherited
 position
 quotes inherited, converter=convertQuotes

[andersr, 2014-10-13 08:54:45]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 08:55:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643893002/240001

[commit-bot: I haz the power, 2014-10-13 11:02:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 11:02:18]

Failed to apply patch for Source/core/css/CSSProperties.in:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSProperties.in
  Hunk #1 FAILED at 233.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/css/CSSProperties.in.rej

Patch:       Source/core/css/CSSProperties.in
Index: Source/core/css/CSSProperties.in
diff --git a/Source/core/css/CSSProperties.in b/Source/core/css/CSSProperties.in
index
7dca218cfaa465c6da631c7137cc9bc7590e4ffa..30580ba38a0b43644e32767c7a1622d58373983d
100644
--- a/Source/core/css/CSSProperties.in
+++ b/Source/core/css/CSSProperties.in
@@ -233,7 +233,7 @@ page-break-before type_name=EPageBreak,
initial=initialPageBreak
 page-break-inside type_name=EPageBreak, initial=initialPageBreak
 paint-order inherited, svg, converter=convertPaintOrder
 perspective animatable, custom_value
-perspective-origin animatable, custom_all
+perspective-origin animatable, converter=convertPerspectiveOrigin
 pointer-events inherited
 position
 quotes inherited, converter=convertQuotes

[commit-bot: I haz the power, 2014-10-13 11:02:19]

The CQ bit was unchecked by commit-bot@chromium.org

[andersr, 2014-10-13 11:08:32]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-13 11:09:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643893002/430001

[commit-bot: I haz the power, 2014-10-13 12:12:34]

Committed patchset #4 (id:430001) as 183600