Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: Source/platform/heap/ThreadState.h

Issue 643883002: Oilpan: Avoid looking up TLS in ThreadState::current() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/heap/ThreadState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/ThreadState.h
diff --git a/Source/platform/heap/ThreadState.h b/Source/platform/heap/ThreadState.h
index 54e561338f10ccdbeae0478031f2e27c7411f688..0eb1cb409f052fed3a00ef21cc41170831ab1960 100644
--- a/Source/platform/heap/ThreadState.h
+++ b/Source/platform/heap/ThreadState.h
@@ -375,7 +375,27 @@ public:
// can no longer use the garbage collected heap after this call.
static void detach();
- static ThreadState* current() { return **s_threadSpecific; }
+ static ThreadState* current()
+ {
+#if defined(__GLIBC__) || OS(ANDROID) || OS(FREEBSD)
+ // TLS lookup is fast in these platforms.
+ return **s_threadSpecific;
+#else
+ uintptr_t dummy;
+ uintptr_t addressDiff = s_mainThreadStackStart - reinterpret_cast<uintptr_t>(&dummy);
+ // This is a fast way to judge if we are in the main thread.
+ // If |&dummy| is within |s_mainThreadUnderestimatedStackSize| byte from
+ // the stack start of the main thread, we judge that we are in
+ // the main thread.
+ if (LIKELY(addressDiff < s_mainThreadUnderestimatedStackSize)) {
+ ASSERT(**s_threadSpecific == mainThreadState());
+ return mainThreadState();
+ }
+ // TLS lookup is slow.
+ return **s_threadSpecific;
+#endif
+ }
+
static ThreadState* mainThreadState()
{
return reinterpret_cast<ThreadState*>(s_mainThreadStateStorage);
@@ -740,6 +760,8 @@ private:
void invokePreFinalizers(Visitor&);
static WTF::ThreadSpecific<ThreadState*>* s_threadSpecific;
+ static uintptr_t s_mainThreadStackStart;
+ static uintptr_t s_mainThreadUnderestimatedStackSize;
static SafePointBarrier* s_safePointBarrier;
// This variable is flipped to true after all threads are stoped
« no previous file with comments | « no previous file | Source/platform/heap/ThreadState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698