Oilpan: Avoid looking up TLS in ThreadState::current()

Source/platform/heap/ThreadState.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 357 matching lines @@
 
     // Associate ThreadState object with the current thread. After this
     // call thread can start using the garbage collected heap infrastructure.
     // It also has to periodically check for safepoints.
     static void attach();
 
     // Disassociate attached ThreadState from the current thread. The thread
     // can no longer use the garbage collected heap after this call.
     static void detach();
 
-    static ThreadState* current() { return **s_threadSpecific; }
+    static ThreadState* current()
+    {
+#if defined(__GLIBC__) || OS(ANDROID) || OS(FREEBSD)
+        // TLS lookup is fast in these platforms.
+        return **s_threadSpecific;
+#else
+        uintptr_t dummy;
+        uintptr_t addressDiff = s_mainThreadStackStart - reinterpret_cast<intptr_t>(&dummy);

[Vyacheslav Egorov (Google), 2014/10/13 14:07:23]

any reason to cast to intptr_t not uintptr_t here?

[haraken, 2014/10/13 15:41:38]

Done.

+        // This is a fast way to judge if we are in the main thread.
+        // If |&dummy| is within |s_mainThreadUnderestimatedStackSize| byte from
+        // the stack start of the main thread, we judge that we are in
+        // the main thread.
+        if (LIKELY(addressDiff <= s_mainThreadUnderestimatedStackSize)) {

[Vyacheslav Egorov (Google), 2014/10/13 14:07:23]

I think s_mainThreadStackStart is exclusive, not inclusive (e.g. it points past
the last page of the stack in linear order) so addressDiff == 0 actually does
not belong to the main thread state.

I think substracting sizeof(void*) from the addressDiff and using < instead of
<= would fix it.

[haraken, 2014/10/13 15:41:38]

Good point. In order to avoid do the subtraction in ThreadState::current()
(which is performance-sensitive), I added the subtraction code to ThreadState's
constructor.

+            ASSERT(**s_threadSpecific == mainThreadState());
+            return mainThreadState();
+        }
+        // TLS lookup is slow.
+        return **s_threadSpecific;
+#endif
+    }
+
     static ThreadState* mainThreadState()
     {
         return reinterpret_cast<ThreadState*>(s_mainThreadStateStorage);
     }
 
     bool isMainThread() const { return this == mainThreadState(); }
     inline bool checkThread() const
     {
         ASSERT(m_thread == currentThread());
         return true;
@@ skipping 344 matching lines @@
     void cleanupPages();
 
     void setLowCollectionRate(bool value) { m_lowCollectionRate = value; }
 
     void performPendingSweepInParallel();
     void waitUntilSweepersDone();
     void unregisterPreFinalizerInternal(void*);
     void invokePreFinalizers(Visitor&);
 
     static WTF::ThreadSpecific<ThreadState*>* s_threadSpecific;
+    static uintptr_t s_mainThreadStackStart;
+    static uintptr_t s_mainThreadUnderestimatedStackSize;
     static SafePointBarrier* s_safePointBarrier;
 
     // This variable is flipped to true after all threads are stoped
     // and outermost GC has started.
     static bool s_inGC;
 
     // We can't create a static member of type ThreadState here
     // because it will introduce global constructor and destructor.
     // We would like to manage lifetime of the ThreadState attached
     // to the main thread explicitly instead and still use normal
@@ skipping 162 matching lines @@
     // whether the page is part of a terminting thread or
     // if the page is traced after being terminated (orphaned).
     uintptr_t m_terminating : 1;
     uintptr_t m_tracedAfterOrphaned : 1;
     uintptr_t m_promptlyFreedSize : 17; // == blinkPageSizeLog2
 };
 
 }
 
 #endif // ThreadState_h