Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 643853002: Support 3 keyboards (Closed)

Created:
6 years, 2 months ago by Shu Chen
Modified:
6 years, 2 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support 3 keyboards: - Russian phonetic (YaZHert) keyboard - Russian phonetic (AATSEEL) keyboard - Maltese keyboard Also support Irish keyboard as login keyboard. BUG=173149 TEST=Verified on linux_chromeos. Committed: https://crrev.com/ec841bf1a39841c6e7efdbb643250432c8ac961c Cr-Commit-Position: refs/heads/master@{#300272}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_input_tools_manifest.json View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/input_method/google_xkb_manifest.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chromeos/ime/component_extension_ime_manager.cc View 1 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 11 (3 generated)
Shu Chen
Nona, can you please review this cl? Thanks This cl is to add more input ...
6 years, 2 months ago (2014-10-18 09:11:51 UTC) #2
Shu Chen
+komatsu@
6 years, 2 months ago (2014-10-20 05:51:41 UTC) #4
Hiro Komatsu
https://codereview.chromium.org/643853002/diff/100001/chromeos/ime/component_extension_ime_manager.cc File chromeos/ime/component_extension_ime_manager.cc (right): https://codereview.chromium.org/643853002/diff/100001/chromeos/ime/component_extension_ime_manager.cc#newcode38 chromeos/ime/component_extension_ime_manager.cc:38: "ie", Please double check if this is an intentional ...
6 years, 2 months ago (2014-10-20 13:33:32 UTC) #5
Shu Chen
https://codereview.chromium.org/643853002/diff/100001/chromeos/ime/component_extension_ime_manager.cc File chromeos/ime/component_extension_ime_manager.cc (right): https://codereview.chromium.org/643853002/diff/100001/chromeos/ime/component_extension_ime_manager.cc#newcode38 chromeos/ime/component_extension_ime_manager.cc:38: "ie", On 2014/10/20 13:33:32, Hiro Komatsu wrote: > Please ...
6 years, 2 months ago (2014-10-20 15:01:11 UTC) #6
Hiro Komatsu
lgtm
6 years, 2 months ago (2014-10-20 15:08:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643853002/100001
6 years, 2 months ago (2014-10-20 15:15:35 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:100001)
6 years, 2 months ago (2014-10-20 15:51:40 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 15:52:16 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ec841bf1a39841c6e7efdbb643250432c8ac961c
Cr-Commit-Position: refs/heads/master@{#300272}

Powered by Google App Engine
This is Rietveld 408576698