Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 643833002: Replace missed OVERRIDE with its C++11 counterparts in src/chromecast (Closed)

Created:
6 years, 2 months ago by RAGHURAM
Modified:
6 years, 2 months ago
CC:
chromium-reviews, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace missed OVERRIDE with its C++11 counterparts in src/chromecast This step is a complete search for missed OVERRIDE to replace it with its lowercase versions. BUG=417463 Committed: https://crrev.com/959e739d80ee433acf94c5af76ef38c63813eaaf Cr-Commit-Position: refs/heads/master@{#299240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chromecast/shell/browser/android/external_video_surface_container_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 2 months ago (2014-10-10 08:37:33 UTC) #2
gunsch
lgtm
6 years, 2 months ago (2014-10-10 20:47:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643833002/1
6 years, 2 months ago (2014-10-11 07:20:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-11 07:59:47 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-11 08:00:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/959e739d80ee433acf94c5af76ef38c63813eaaf
Cr-Commit-Position: refs/heads/master@{#299240}

Powered by Google App Engine
This is Rietveld 408576698