Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: base/android/library_loader/library_loader_hooks.cc

Issue 643803003: Add UMA for testing whether device supports memory mapping APK files with executable permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/library_loader/library_loader_hooks.cc
diff --git a/base/android/library_loader/library_loader_hooks.cc b/base/android/library_loader/library_loader_hooks.cc
index 87f791090b0a4cb6607e8457e33adeab1e311aeb..b98802ac791443e61ee45e3b903c933873a3b698 100644
--- a/base/android/library_loader/library_loader_hooks.cc
+++ b/base/android/library_loader/library_loader_hooks.cc
@@ -31,7 +31,7 @@ static void InitCommandLine(JNIEnv* env, jclass clazz,
}
static jboolean LibraryLoaded(JNIEnv* env, jclass clazz) {
- if(g_registration_callback == NULL) {
+ if (g_registration_callback == NULL) {
return true;
}
return g_registration_callback(env, clazz);
@@ -48,6 +48,14 @@ static void RecordChromiumAndroidLinkerHistogram(
is_low_memory_device);
}
+static void RecordChromiumAndroidLinkerLoadFromApkSucceededHistogram(
+ JNIEnv* env,
picksi1 2014/10/10 10:52:17 Is this the naming convention? If so fine, otherwi
petrcermak 2014/10/10 14:20:14 I moved the code to the existing RecordChromiumAnd
+ jclass clazz,
+ jboolean success) {
+ UMA_HISTOGRAM_BOOLEAN("ChromiumAndroidLinker.LoadFromApkSucceeded",
+ success);
+}
+
void LibraryLoaderExitHook() {
if (g_at_exit_manager) {
delete g_at_exit_manager;

Powered by Google App Engine
This is Rietveld 408576698