Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: pkg/analysis_server/lib/src/services/completion/local_computer.dart

Issue 643803002: suppress suggestions in string literals (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/local_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/local_computer.dart b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
index b7c83b532bf9b9f8a96d10a4d6c722d3bf67d17a..05b0ad41828a62333c13be1aff857693fb0fa063 100644
--- a/pkg/analysis_server/lib/src/services/completion/local_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/local_computer.dart
@@ -85,11 +85,6 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {
}
@override
- visitCombinator(Combinator node) {
- // Handled by ImportedComputer
- }
-
- @override
visitCascadeExpression(CascadeExpression node) {
Expression target = node.target;
// This computer handles the expression
@@ -119,6 +114,11 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {
}
@override
+ visitCombinator(Combinator node) {
+ // Handled by ImportedComputer
+ }
+
+ @override
visitCompilationUnit(CompilationUnit node) {
node.declarations.forEach((Declaration declaration) {
if (declaration is ClassDeclaration) {
@@ -199,6 +199,11 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {
}
@override
+ visitInterpolationExpression(InterpolationExpression node) {
+ visitNode(node);
+ }
+
+ @override
visitMethodDeclaration(MethodDeclaration node) {
_addParamListSuggestions(node.parameters);
visitNode(node);
@@ -225,6 +230,11 @@ class _LocalVisitor extends GeneralizingAstVisitor<dynamic> {
}
@override
+ visitStringLiteral(StringLiteral node) {
+ // ignore
+ }
+
+ @override
visitTypeName(TypeName node) {
// If suggesting completions within a TypeName node
// then limit suggestions to only types
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/completion/completion_test_util.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698