Issue 643793003: Revert "Ensure that the browser’s copy of page id is in sync with the renderer’s."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 643793003: Revert "Ensure that the browser’s copy of page id is in sync with the renderer’s." (Closed)

Created:
6 years, 2 months ago by Avi (use Gerrit)

Modified:
6 years, 2 months ago

Reviewers:
Robert Sesek, Charlie Reis

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert "Ensure that the browser’s copy of page id is in sync with the renderer’s." This reverts commit 31111d18aadc37181a249afa74a62ac46544e12e. Conflicts: content/browser/web_contents/web_contents_impl.h BUG=407376 TEST=no crashing, we hope TBR=rsesek@chromium.org, creis@chromium.org Committed: https://crrev.com/24913e041da6d1f6b7adffa1a291229def040ccc Cr-Commit-Position: refs/heads/master@{#300510}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -35 lines)			Patch
M	chrome/common/crash_keys.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/frame_host/render_frame_host_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_delegate.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	2 chunks	+0 lines, -25 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643793003/1

6 years, 2 months ago (2014-10-21 16:06:37 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 17:18:22 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/24913e041da6d1f6b7adffa1a291229def040ccc
Cr-Commit-Position: refs/heads/master@{#300510}