Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 643783005: X87: Eliminate special keyed load string stub in favor of uniform handlers (Closed)

Created:
6 years, 2 months ago by chunyang.dai
Modified:
6 years, 2 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Eliminate special keyed load string stub in favor of uniform handlers port r24661. original commit message: Eliminate special keyed load string stub in favor of uniform handlers. KeyedLoadIC installs a special case if the receiver is a string. Although there are several maps for strings, in practice we seem to be able to treat them individually because a given KeyedLoad site only sees 1-2 string types BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -27 lines) Patch
M src/ic/x87/ic-x87.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
chunyang.dai
WL. PTAL.
6 years, 2 months ago (2014-10-17 04:44:26 UTC) #2
Weiliang
lgtm
6 years, 2 months ago (2014-10-17 05:23:01 UTC) #3
Weiliang
6 years, 2 months ago (2014-10-17 05:24:59 UTC) #4
Committed as r24674

Powered by Google App Engine
This is Rietveld 408576698