Issue 643773003: Revert of DevTools: fix styles for glasspane

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 643773003: Revert of DevTools: fix styles for glasspane (Closed)

Created:
6 years, 2 months ago by apavlov

Modified:
6 years, 2 months ago

Reviewers:
lushnikov, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of DevTools: fix styles for glasspane (patchset #3 id:40001 of https://codereview.chromium.org/659043002/) Reason for revert: A better solution has been landed in https://src.chromium.org/viewvc/blink?view=rev&revision=183868 Original issue's description: > DevTools: fix styles for glasspane > > The glasspane should be a component-root so that it inherits all the > basic styling. > > R=pfeldman > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183813 TBR=pfeldman@chromium.org,lushnikov@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183869

Patch Set 1 #

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	Source/devtools/front_end/ui/Dialog.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/devtools/front_end/ui/SoftContextMenu.js	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643773003/1

6 years, 2 months ago (2014-10-17 09:37:07 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-17 09:37:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183869

Expand Messages | Collapse Messages