Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 643773002: Run app_shell_browsertests on Win waterfall and trybots. (Closed)

Created:
6 years, 2 months ago by Yoyo Zhou
Modified:
6 years, 1 month ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Run app_shell_browsertests on Win waterfall and trybots. BUG=399363 Committed: https://crrev.com/b0cf851116b7013bcc3badedb37cd080935a677b Cr-Commit-Position: refs/heads/master@{#301405}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M testing/buildbot/chromium.win.json View 1 5 chunks +5 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Yoyo Zhou
It passes the Win trybots.
6 years, 2 months ago (2014-10-10 00:13:02 UTC) #2
Yoyo Zhou
On 2014/10/10 00:13:02, Yoyo Zhou wrote: > It passes the Win trybots. Sorry - I ...
6 years, 2 months ago (2014-10-10 01:54:37 UTC) #3
Yoyo Zhou
After Lucas's fix, the tests are now passing on the trybots. Paweł, can you look ...
6 years, 2 months ago (2014-10-22 22:43:04 UTC) #4
Paweł Hajdan Jr.
LGTM
6 years, 1 month ago (2014-10-27 11:55:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643773002/160001
6 years, 1 month ago (2014-10-27 18:04:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:160001)
6 years, 1 month ago (2014-10-27 19:29:22 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:30:47 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0cf851116b7013bcc3badedb37cd080935a677b
Cr-Commit-Position: refs/heads/master@{#301405}

Powered by Google App Engine
This is Rietveld 408576698