content/browser/renderer_host/render_process_host_impl.cc - Issue 643733002: Add RoutingIDIssuer to ensure the correctness of ID to be routed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 643733002: Add RoutingIDIssuer to ensure the correctness of ID to be routed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/site_per_process_accessibility_browsertest.cc ('k') | content/browser/renderer_host/render_widget_helper.h » ('j') | content/browser/renderer_host/render_widget_helper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index c41c4054371c6c0270bd09b9d5d48dac1187c921..25f18f7c24da01db44f9d8b4b85bc10bb2b16fcb 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -920,6 +920,7 @@ ServiceRegistry* RenderProcessHostImpl::GetServiceRegistry() {

void RenderProcessHostImpl::AddRoute(

int32 routing_id,

IPC::Listener* listener) {

+ DCHECK(widget_helper_->IsRoutingIDProbablyValid(routing_id));

// We already have DCHECK() in IDMap. This is for chasing

// crbug.com/415059 and can be removed after fixing it.

CHECK(!listeners_.Lookup(routing_id));