content/browser/accessibility/site_per_process_accessibility_browsertest.cc - Issue 643733002: Add RoutingIDIssuer to ensure the correctness of ID to be routed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

Issue 643733002: Add RoutingIDIssuer to ensure the correctness of ID to be routed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

diff --git a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

index fdc0dc6a8a7417d7475c2c878a4d38aa5c79d9a4..6622a14598121b1e2beb275a217532340c5a3202 100644

--- a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

+++ b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc

@@ -22,6 +22,7 @@

#include "content/public/test/browser_test_utils.h"

#include "content/public/test/content_browser_test.h"

#include "content/public/test/content_browser_test_utils.h"

+#include "content/public/test/routing_id_mangling_disabler.h"

#include "content/public/test/test_utils.h"

#include "content/shell/browser/shell.h"

#include "content/test/accessibility_browser_test_utils.h"

@@ -35,6 +36,11 @@ class SitePerProcessAccessibilityBrowserTest

: public SitePerProcessBrowserTest {

public:

SitePerProcessAccessibilityBrowserTest() {}

+ // TODO(morrita): This is fishy. This test shouldn't rely on the

+ // abasence of routing_id mangling. Something seems wrong.

+ // See http://crbug.com/422136 for more updates.

+ content::RoutingIDManglingDisabler mangling_disabler_;

};

// TODO(nasko): try enabling this test on more platforms once