Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 643703009: MediaSourcePlayer: Handle the case where key is added during decoding. (Closed)

Created:
6 years, 1 month ago by xhwang
Modified:
6 years, 1 month ago
Reviewers:
*qinmin, *gunsch
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

MediaSourcePlayer: Handle the case where key is added during decoding. BUG=b/18035688 TEST=Tested manually. Committed: https://crrev.com/3c3ce310690866d82216045a6e2e2abdb335397b Cr-Commit-Position: refs/heads/master@{#301278}

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -6 lines) Patch
M media/base/android/media_source_player.h View 2 chunks +10 lines, -0 lines 0 comments Download
M media/base/android/media_source_player.cc View 1 5 chunks +42 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xhwang
PTAL https://codereview.chromium.org/643703009/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (right): https://codereview.chromium.org/643703009/diff/1/media/base/android/media_source_player.cc#newcode520 media/base/android/media_source_player.cc:520: // performance impact should be pretty small. qinmin: ...
6 years, 1 month ago (2014-10-24 23:24:11 UTC) #3
qinmin
ok to submit as a temporary fix, but as i pointed out, there is still ...
6 years, 1 month ago (2014-10-24 23:45:56 UTC) #4
qinmin
lgtm
6 years, 1 month ago (2014-10-24 23:46:10 UTC) #5
gunsch
lgtm https://codereview.chromium.org/643703009/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (right): https://codereview.chromium.org/643703009/diff/1/media/base/android/media_source_player.cc#newcode790 media/base/android/media_source_player.cc:790: DVLOG(2) << __FUNCTION__; nit: rest of file is ...
6 years, 1 month ago (2014-10-24 23:51:04 UTC) #6
xhwang
https://codereview.chromium.org/643703009/diff/1/media/base/android/media_source_player.cc File media/base/android/media_source_player.cc (right): https://codereview.chromium.org/643703009/diff/1/media/base/android/media_source_player.cc#newcode520 media/base/android/media_source_player.cc:520: // performance impact should be pretty small. On 2014/10/24 ...
6 years, 1 month ago (2014-10-25 00:11:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643703009/20001
6 years, 1 month ago (2014-10-25 00:19:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-25 06:31:25 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-25 06:32:03 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c3ce310690866d82216045a6e2e2abdb335397b
Cr-Commit-Position: refs/heads/master@{#301278}

Powered by Google App Engine
This is Rietveld 408576698