Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/guest_view/web_view/web_view_apitest.cc

Issue 643703007: Adding app_view tests to app_shell_browsertests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multiple_apps
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/app_view/app_view_apitest.cc ('k') | extensions/shell/app_shell.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/web_view_apitest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_apitest.cc b/extensions/browser/guest_view/web_view/web_view_apitest.cc
index 76de4d63929f74468ebea9f3cd8ce88e2cd18a9b..6f052ab409f26a614b96c899ba99f19b7e65c010 100644
--- a/extensions/browser/guest_view/web_view/web_view_apitest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_apitest.cc
@@ -161,12 +161,10 @@ void WebViewAPITest::RunTest(const std::string& test_name,
ExtensionTestMessageListener done_listener("TEST_PASSED", false);
done_listener.set_failure_message("TEST_FAILED");
- if (!content::ExecuteScript(
- embedder_web_contents_,
- base::StringPrintf("runTest('%s')", test_name.c_str()))) {
- LOG(ERROR) << "Unable to start test.";
- return;
- }
+ ASSERT_TRUE(content::ExecuteScript(
+ embedder_web_contents_,
+ base::StringPrintf("runTest('%s')", test_name.c_str())))
+ << "Unable to start test.";
ASSERT_TRUE(done_listener.WaitUntilSatisfied());
}
« no previous file with comments | « extensions/browser/guest_view/app_view/app_view_apitest.cc ('k') | extensions/shell/app_shell.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698