Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: Source/core/svg/SVGTextPathElement.cpp

Issue 643703006: SVGElement::parseAttribute resolves property via property map (Step 2.4) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: aut Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGTextPathElement.h ('k') | Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGTextPathElement.cpp
diff --git a/Source/core/svg/SVGTextPathElement.cpp b/Source/core/svg/SVGTextPathElement.cpp
index f2decf8ee0965d94bc40c3da34ea8723e0006a34..fa5b97ac5a2d10a9f4d499d4122b076f744472c8 100644
--- a/Source/core/svg/SVGTextPathElement.cpp
+++ b/Source/core/svg/SVGTextPathElement.cpp
@@ -86,25 +86,6 @@ bool SVGTextPathElement::isSupportedAttribute(const QualifiedName& attrName)
return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
}
-void SVGTextPathElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
-{
- SVGParsingError parseError = NoError;
-
- if (!isSupportedAttribute(name))
- SVGTextContentElement::parseAttribute(name, value);
- else if (name == SVGNames::startOffsetAttr)
- m_startOffset->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::methodAttr)
- m_method->setBaseValueAsString(value, parseError);
- else if (name == SVGNames::spacingAttr)
- m_spacing->setBaseValueAsString(value, parseError);
- else if (SVGURIReference::parseAttribute(name, value, parseError)) {
- } else
- ASSERT_NOT_REACHED();
-
- reportAttributeParsingError(parseError, name, value);
-}
-
void SVGTextPathElement::svgAttributeChanged(const QualifiedName& attrName)
{
if (!isSupportedAttribute(attrName)) {
« no previous file with comments | « Source/core/svg/SVGTextPathElement.h ('k') | Source/core/svg/SVGURIReference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698