SVGElement::parseAttribute resolves property via property map (Step 2.4)

SVGElement::parseAttribute resolves property via property map (Step 2.4)

This is to replace the existing |SVGElement::parseAttribute| implementation,
but as there are many callers, we would like to proceed this incrementally.
a) Introduce |SVGElement::parseAttributeNew| *LANDED*
b) Convert all overrides |SVGElement::parseAttribute| to
   a |parseAttributeNew| call. <-- This patch
c) Replace existing |parseAttribute| with |parseAttributeNew|, and remove all
   overrides simply calling |parseAttributeNew|

This patch is (b).

BUG=397902
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183736

[kouhei (in TOK), 2014-10-15 08:34:42]

kouhei@chromium.org changed reviewers:
+ fs@opera.com, haraken@chromium.org, pdr@chromium.org

[kouhei (in TOK), 2014-10-15 08:34:42]

more code removals.

[fs, 2014-10-15 09:06:46]

LGTM - handle the below at your own discretion.

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGCursorEle...
File Source/core/svg/SVGCursorElement.cpp (right):

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGCursorEle...
Source/core/svg/SVGCursorElement.cpp:47: for (const auto& client : m_clients)
It looks a bit dodgy with 'const' here, but I guess it happens to work because
it'll be 'const RawPtr<SVGElement>'... (same below)

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGMPathElem...
File Source/core/svg/SVGMPathElement.cpp (right):

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGMPathElem...
Source/core/svg/SVGMPathElement.cpp:104: }
When eliding the call to the superclass it might be good to make a note of why.
(In this case I can see that it's of little use to do so.)

[kouhei (in TOK), 2014-10-15 10:02:00]

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGCursorEle...
File Source/core/svg/SVGCursorElement.cpp (right):

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGCursorEle...
Source/core/svg/SVGCursorElement.cpp:47: for (const auto& client : m_clients)
On 2014/10/15 09:06:45, fs wrote:
> It looks a bit dodgy with 'const' here, but I guess it happens to work because
> it'll be 'const RawPtr<SVGElement>'... (same below)

Changed to auto&.

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGMPathElem...
File Source/core/svg/SVGMPathElement.cpp (right):

https://codereview.chromium.org/643703006/diff/1/Source/core/svg/SVGMPathElem...
Source/core/svg/SVGMPathElement.cpp:104: }
On 2014/10/15 09:06:45, fs wrote:
> When eliding the call to the superclass it might be good to make a note of
why.
> (In this case I can see that it's of little use to do so.)
Thanks for the catch.

This was by accident. The missing call might break css matches.

[kouhei (in TOK), 2014-10-15 10:02:37]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-10-15 10:03:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/643703006/20001

[commit-bot: I haz the power, 2014-10-15 11:02:20]

Committed patchset #2 (id:20001) as 183736