Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 643703005: Test srcset parsing for space in url (Closed)

Created:
6 years, 2 months ago by Yoav Weiss
Modified:
6 years, 2 months ago
Reviewers:
cbiesinger
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Test srcset parsing for space in url A false bug report led me to the realization that srcset's unit testing didn't include URLs with encoded spaces in them. Added such a test here. BUG=422914 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/html/parser/HTMLSrcsetParserTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Yoav Weiss
6 years, 2 months ago (2014-10-16 18:39:41 UTC) #2
cbiesinger
lgtm
6 years, 2 months ago (2014-10-17 00:18:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643703005/1
6 years, 2 months ago (2014-10-17 04:30:38 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 04:41:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183858

Powered by Google App Engine
This is Rietveld 408576698