Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 643693003: Fix compilation error due to removal of implicit scoped_refptr to ptr conversion. (Closed)

Created:
6 years, 2 months ago by mef
Modified:
6 years, 2 months ago
Reviewers:
mmenke, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix compilation error due to removal of implicit scoped_refptr to ptr conversion. BUG= Committed: https://crrev.com/5c3df976cae9904982b2914870dd081b7318b8a2 Cr-Commit-Position: refs/heads/master@{#298993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M components/cronet/android/url_request_adapter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/cronet/android/wrapped_channel_upload_element_reader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mef
6 years, 2 months ago (2014-10-09 21:00:36 UTC) #2
mmenke
LGTM!
6 years, 2 months ago (2014-10-09 21:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643693003/1
6 years, 2 months ago (2014-10-09 21:05:23 UTC) #5
xunjieli
Thanks for fixing this! It's interesting to know that they are removing this implicit conversion. ...
6 years, 2 months ago (2014-10-09 22:01:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 22:21:15 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 22:23:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c3df976cae9904982b2914870dd081b7318b8a2
Cr-Commit-Position: refs/heads/master@{#298993}

Powered by Google App Engine
This is Rietveld 408576698