Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 643643003: Rename minidump_test_util.* to minidump_file_writer_test_util.* (Closed)

Created:
6 years, 2 months ago by Mark Mentovai
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Rename minidump_test_util.* to minidump_file_writer_test_util.*. This is in line with the other new minidump_*_test_util files, namely, the “context” and “memory” ones. minidump_file_writer_test_util.* provides VerifyMinidumpHeader(), which is used to validate the MINIDUMP_HEADER at the beginning of a minidump file, as written by MinidumpFileWriter. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/c182be95a2498ddbe0efa6b8ba27a95547ab230c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -89 lines) Patch
M minidump/minidump.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M minidump/minidump_exception_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_file_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
A + minidump/minidump_file_writer_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + minidump/minidump_file_writer_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_memory_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_misc_info_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_module_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M minidump/minidump_system_info_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D minidump/minidump_test_util.h View 1 chunk +0 lines, -41 lines 0 comments Download
D minidump/minidump_test_util.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 2 months ago (2014-10-09 19:34:43 UTC) #2
Robert Sesek
LGTM
6 years, 2 months ago (2014-10-09 21:06:48 UTC) #3
Mark Mentovai
6 years, 2 months ago (2014-10-09 21:08:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c182be95a2498ddbe0efa6b8ba27a95547ab230c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698