Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: src/ast.cc

Issue 643633003: AST nodes have at most one bailout/typefeedback ID now, saving lots of memory. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.cc
diff --git a/src/ast.cc b/src/ast.cc
index 55a5ca18cf8677040dfc3f2fecd914a1d95bd4d6..867cfa9bc7a26de51e8f17cf32614a9797381bb9 100644
--- a/src/ast.cc
+++ b/src/ast.cc
@@ -61,7 +61,7 @@ bool Expression::IsUndefinedLiteral(Isolate* isolate) const {
VariableProxy::VariableProxy(Zone* zone, Variable* var, int position,
IdGen* id_gen)
- : Expression(zone, position, id_gen),
+ : Expression(zone, position, 0, id_gen),
raw_name_(var->raw_name()),
interface_(var->interface()),
variable_feedback_slot_(kInvalidFeedbackSlot),
@@ -74,7 +74,7 @@ VariableProxy::VariableProxy(Zone* zone, Variable* var, int position,
VariableProxy::VariableProxy(Zone* zone, const AstRawString* name, bool is_this,
Interface* interface, int position, IdGen* id_gen)
- : Expression(zone, position, id_gen),
+ : Expression(zone, position, 0, id_gen),
raw_name_(name),
interface_(interface),
variable_feedback_slot_(kInvalidFeedbackSlot),
@@ -99,12 +99,11 @@ void VariableProxy::BindTo(Variable* var) {
Assignment::Assignment(Zone* zone, Token::Value op, Expression* target,
Expression* value, int pos, IdGen* id_gen)
- : Expression(zone, pos, id_gen),
+ : Expression(zone, pos, num_ids(), id_gen),
op_(op),
target_(target),
value_(value),
binary_operation_(NULL),
- assignment_id_(id_gen->GetNextId()),
is_uninitialized_(false),
store_mode_(STANDARD_STORE) {}
@@ -989,12 +988,10 @@ RegExpAlternative::RegExpAlternative(ZoneList<RegExpTree*>* nodes)
CaseClause::CaseClause(Zone* zone, Expression* label,
ZoneList<Statement*>* statements, int pos, IdGen* id_gen)
- : Expression(zone, pos, id_gen),
+ : Expression(zone, pos, num_ids(), id_gen),
label_(label),
statements_(statements),
- compare_type_(Type::None(zone)),
- compare_id_(id_gen->GetNextId()),
- entry_id_(id_gen->GetNextId()) {}
+ compare_type_(Type::None(zone)) {}
#define REGULAR_NODE(NodeType) \
« no previous file with comments | « src/ast.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698