Issue 643613002: Revert of Implemented retrieval of alerts history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 643613002: Revert of Implemented retrieval of alerts history (Closed)

Created:
6 years, 2 months ago by Sergiy Byelozyorov

Modified:
6 years, 2 months ago

Reviewers:
Z_DONOTUSE, ojan

CC:
ojan, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

Revert of Implemented retrieval of alerts history (patchset #4 id:60001 of https://codereview.chromium.org/633983002/) Reason for revert: This breaks sheriff-o-matic, although not clear why. Original issue's description: > Implemented retrieval of alerts history. > > BUG=416182 > R=ojan@chromium.org > CC=phajdan.jr@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183431 TBR=ojan@chromium.org,ojan@google.com NOTREECHECKS=true NOTRY=true BUG=416182 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183458

Created: 6 years, 2 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -150 lines)			Patch
M	Tools/GardeningServer/alerts.py	View	5 chunks	+10 lines, -57 lines	0 comments	Download
M	Tools/GardeningServer/alerts_test.py	View	3 chunks	+0 lines, -64 lines	0 comments	Download
M	Tools/GardeningServer/app.yaml	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Tools/GardeningServer/internal_alerts.py	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Tools/GardeningServer/internal_alerts_test.py	View	2 chunks	+0 lines, -22 lines	0 comments	Download

Total messages: 3 (0 generated)

Sergiy Byelozyorov

Created Revert of Implemented retrieval of alerts history

6 years, 2 months ago (2014-10-09 12:47:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643613002/1

6 years, 2 months ago (2014-10-09 12:48:25 UTC) #2

commit-bot: I haz the power

6 years, 2 months ago (2014-10-09 12:49:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183458