Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 643603002: Simplify Scope and ScopePtr conversions. (Closed)

Created:
6 years, 2 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Simplify Scope and ScopePtr conversions. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24488

Patch Set 1 #

Patch Set 2 : Rebased before landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M src/parser.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/preparser.h View 1 6 chunks +5 lines, -35 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
Sven, WDYT?
6 years, 2 months ago (2014-10-09 08:56:04 UTC) #1
Sven Panne
lgtm
6 years, 2 months ago (2014-10-09 09:47:21 UTC) #2
Dmitry Lomov (no reviews)
6 years, 2 months ago (2014-10-09 10:40:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24488 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698