Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 643543002: Remove empty recordy.gypi file. (Closed)

Created:
6 years, 2 months ago by tfarina
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove empty recordy.gypi file. Fixes the TODO in that file. BUG=None TEST=None R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/93bee71a41701eb6cb55fe6df50f3a4081cc8a01

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
D gyp/record.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tfarina
Depends on this Chromium CL -> https://codereview.chromium.org/644623002/ ptal.
6 years, 2 months ago (2014-10-09 03:23:21 UTC) #1
mtklein
Lgtm once the other CL lands.
6 years, 2 months ago (2014-10-09 12:53:02 UTC) #2
reed1
lgtm
6 years, 2 months ago (2014-10-09 15:48:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643543002/1
6 years, 2 months ago (2014-10-09 15:48:38 UTC) #6
tfarina
I unchecked the cq box. Chromium CL (https://codereview.chromium.org/644623002/) needs to land first, otherwise when Skia ...
6 years, 2 months ago (2014-10-09 15:50:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643543002/1
6 years, 2 months ago (2014-10-10 20:26:55 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 20:34:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 93bee71a41701eb6cb55fe6df50f3a4081cc8a01

Powered by Google App Engine
This is Rietveld 408576698