Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/autofill/content/renderer/password_generation_agent.h

Issue 643493003: [Password Generation] Update UMA stats for popups per page not per event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_generation_agent.h
diff --git a/components/autofill/content/renderer/password_generation_agent.h b/components/autofill/content/renderer/password_generation_agent.h
index a2c1c12c2c517abbe9a41c8647a00c7454c887a8..5320e5c239b03b8fb15743fe0a7da5fdbd53c2f0 100644
--- a/components/autofill/content/renderer/password_generation_agent.h
+++ b/components/autofill/content/renderer/password_generation_agent.h
@@ -107,6 +107,16 @@ class PasswordGenerationAgent : public content::RenderViewObserver {
// stats.
bool password_edited_;
+ // True if the generation popup was shown during this navigation. Used to
+ // track UMA stats per page visit not per display, since the former is more
Ilya Sherman 2014/10/09 22:03:58 nit: "not per display" -> "rather than per display
Garrett Casto 2014/10/14 18:40:05 Done.
+ // interesting.
+ bool generation_popup_shown_;
+
+ // True if the editing popup was shown during this navigation. Used to track
+ // UMA stats per page instead of per display since the former is more
Ilya Sherman 2014/10/09 22:03:58 nit: "instead of per display since" -> "rather tha
Garrett Casto 2014/10/14 18:40:05 Done.
+ // interesting.
+ bool editing_popup_shown_;
+
// If this feature is enabled. Controlled by Finch.
bool enabled_;

Powered by Google App Engine
This is Rietveld 408576698