[Password Generation] Update UMA stats for popups per page not per event.

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include "base/memory/scoped_ptr.h"
+#include "base/metrics/histogram_samples.h"
+#include "base/metrics/statistics_recorder.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/test_password_generation_agent.h"
 #include "components/autofill/core/common/form_data.h"
+#include "components/autofill/core/common/password_generation_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebWidget.h"
 
 using blink::WebDocument;
 using blink::WebElement;
 using blink::WebInputElement;
 using blink::WebNode;
@@ skipping 297 matching lines @@
   ExecuteJavaScript("document.getElementById('username').focus();");
   EXPECT_EQ(0u, password_generation_->messages().size());
   password_generation_->clear_messages();
 
   // Focusing the password field will bring up the generation UI again.
   ExecuteJavaScript("document.getElementById('first_password').focus();");
   EXPECT_EQ(1u, password_generation_->messages().size());
   EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,
             password_generation_->messages()[0]->type());
   password_generation_->clear_messages();
+
+  // Loading a different page triggers UMA stat upload. Verify that only one
+  // display event is sent even though
+  LoadHTML(kSigninFormHTML);
+
+  base::HistogramBase* event_histogram =
+      base::StatisticsRecorder::FindHistogram(
+          "PasswordGeneration.Event");
+  ASSERT_TRUE(event_histogram);
+  scoped_ptr<base::HistogramSamples> snapshot =
+      event_histogram->SnapshotSamples();
+  EXPECT_EQ(1, snapshot->GetCount(
+      autofill::password_generation::GENERATION_POPUP_SHOWN));

[Ilya Sherman, 2014/10/09 22:03:58]

Please use base/test/histogram_tester.h for this.

[Garrett Casto, 2014/10/14 18:40:05]

Neat, didn't know about that. Updated.

 }
 
 }  // namespace autofill