Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: components/autofill/core/common/password_generation_util.h

Issue 643493003: [Password Generation] Update UMA stats for popups per page not per event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_
7 7
8 namespace autofill { 8 namespace autofill {
9 namespace password_generation { 9 namespace password_generation {
10 10
(...skipping 11 matching lines...) Expand all
22 22
23 // DEPRECATED: Password generation bubble shown (old UI). 23 // DEPRECATED: Password generation bubble shown (old UI).
24 DEPRECATED_BUBBLE_SHOWN, 24 DEPRECATED_BUBBLE_SHOWN,
25 25
26 // Password generation could be triggered if the user selects the appropriate 26 // Password generation could be triggered if the user selects the appropriate
27 // element. 27 // element.
28 GENERATION_AVAILABLE, 28 GENERATION_AVAILABLE,
29 29
30 // Password generation popup is shown after user focuses the appropriate 30 // Password generation popup is shown after user focuses the appropriate
31 // password field. 31 // password field.
32 GENERATION_POPUP_SHOWN, 32 // DEPRECATED: These reports were triggered when the popup could have shown
33 // not when it did show so they paint an unreliable picture. Newer stats
34 // are only incremented per page, which is more useful to judge the
35 // effectiveness of the UI.
36 DEPRECATED_GENERATION_POPUP_SHOWN,
33 37
34 // Generated password was accepted by the user. 38 // Generated password was accepted by the user.
35 PASSWORD_ACCEPTED, 39 PASSWORD_ACCEPTED,
36 40
37 // User focused the password field containing the generated password. 41 // User focused the password field containing the generated password.
38 EDITING_POPUP_SHOWN, 42 // DEPRECATED: These reports were triggered when the popup could have shown
43 // not when it did show so they paint an unreliable picture. Newer stats
44 // are only incremented per page, which is more useful to judge the
45 // effectiveness of the UI.
46 DEPRECATED_EDITING_POPUP_SHOWN,
39 47
40 // Password was changed after generation. 48 // Password was changed after generation.
41 PASSWORD_EDITED, 49 PASSWORD_EDITED,
42 50
43 // Generated password was deleted by the user 51 // Generated password was deleted by the user
44 PASSWORD_DELETED, 52 PASSWORD_DELETED,
45 53
54 // Password generation popup is shown after user focuses the appropriate
55 // password field.
56 GENERATION_POPUP_SHOWN,
57
58 // User focused the password field containing the generated password.
59 EDITING_POPUP_SHOWN,
60
46 // Number of enum entries, used for UMA histogram reporting macros. 61 // Number of enum entries, used for UMA histogram reporting macros.
47 EVENT_ENUM_COUNT 62 EVENT_ENUM_COUNT
48 }; 63 };
49 64
50 // Wrapper to store the user interactions with the password generation bubble. 65 // Wrapper to store the user interactions with the password generation bubble.
51 struct PasswordGenerationActions { 66 struct PasswordGenerationActions {
52 // Whether the user has clicked on the learn more link. 67 // Whether the user has clicked on the learn more link.
53 bool learn_more_visited; 68 bool learn_more_visited;
54 69
55 // Whether the user has accepted the generated password. 70 // Whether the user has accepted the generated password.
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 }; 108 };
94 109
95 // Returns true if Password Generation is enabled according to the field 110 // Returns true if Password Generation is enabled according to the field
96 // trial result and the flags. 111 // trial result and the flags.
97 bool IsPasswordGenerationEnabled(); 112 bool IsPasswordGenerationEnabled();
98 113
99 } // namespace password_generation 114 } // namespace password_generation
100 } // namespace autofill 115 } // namespace autofill
101 116
102 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_ 117 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_GENERATION_UTIL_H_
OLDNEW
« no previous file with comments | « components/autofill/content/renderer/password_generation_agent.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698