tools/metrics/histograms/histograms.xml - Issue 643493003: [Password Generation] Update UMA stats for popups per page not per event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 643493003: [Password Generation] Update UMA stats for popups per page not per event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 6446d031a849225eadfe9606352758f9ef6b108a..31068bd795d16d5f7336dde6bf9a5b8703992d2b 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -48605,11 +48605,13 @@ To add a new entry, add it with any value and run test to compute valid value.

- <int value="5" label="Generation popup shown"/>

+ <int value="5" label="DEPRECATED:Generation popup shown"/>

Ilya Sherman 2014/10/14 20:17:20 nit: Please leave a space after "DEPRECATED:"; dit

Garrett Casto 2014/10/15 00:10:01 Done.

- <int value="7" label="Editing popup shown"/>

+ <int value="7" label="DEPRECATED:Editing popup shown"/>

+ <int value="10" label="Generated popup shown (limit once per page)"/>

+ <int value="11" label="Editing popup shown (limit once per page)"/>

</enum>

« chrome/renderer/autofill/password_generation_agent_browsertest.cc ('K') | « components/autofill/core/common/password_generation_util.h ('k') | no next file » | no next file with comments »