Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3979)

Unified Diff: chrome/browser/profiles/profile_io_data.h

Issue 643443002: Move data_reduction_proxy_enabled pref to profile_impl_io_data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed mmenke's comments. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_io_data.h
diff --git a/chrome/browser/profiles/profile_io_data.h b/chrome/browser/profiles/profile_io_data.h
index f49e3e847b17319e435ec05df5167ce6b23083b5..95c7aeb454cd227ef8b4ffd5e25ecc045bb3fdbc 100644
--- a/chrome/browser/profiles/profile_io_data.h
+++ b/chrome/browser/profiles/profile_io_data.h
@@ -183,12 +183,6 @@ class ProfileIOData {
return &safe_browsing_enabled_;
}
- // TODO(feng): move the function to protected area.
- // IsDataReductionProxyEnabled() should be used as public API.
- BooleanPrefMember* data_reduction_proxy_enabled() const {
- return &data_reduction_proxy_enabled_;
- }
-
BooleanPrefMember* printing_enabled() const {
return &printing_enabled_;
}
@@ -261,7 +255,7 @@ class ProfileIOData {
// Returns whether or not data reduction proxy is enabled in the browser
// instance on which this profile resides.
- bool IsDataReductionProxyEnabled() const;
+ virtual bool IsDataReductionProxyEnabled() const;
void set_client_cert_store_factory_for_testing(
const base::Callback<scoped_ptr<net::ClientCertStore>()>& factory) {
@@ -614,7 +608,6 @@ class ProfileIOData {
mutable BooleanPrefMember enable_do_not_track_;
mutable BooleanPrefMember force_safesearch_;
mutable BooleanPrefMember safe_browsing_enabled_;
- mutable BooleanPrefMember data_reduction_proxy_enabled_;
mutable BooleanPrefMember printing_enabled_;
mutable BooleanPrefMember sync_disabled_;
mutable BooleanPrefMember signin_allowed_;
« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698