Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 643443002: Move data_reduction_proxy_enabled pref to profile_impl_io_data. (Closed)

Created:
6 years, 2 months ago by Not at Google. Contact bengr
Modified:
6 years, 2 months ago
Reviewers:
mmenke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move data_reduction_proxy_enabled pref to profile_impl_io_data. Data reduction proxy should never be enabled for incognito tabs. So moving it to profile_impl_io_data which is specific to non-ingocnito. BUG=412873 Committed: https://crrev.com/08371872bc74c3ecfee9115551adb1e66fa5532d Cr-Commit-Position: refs/heads/master@{#299020}

Patch Set 1 #

Patch Set 2 : Minor whitespace change #

Total comments: 2

Patch Set 3 : Addressed mmenke's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Not at Google. Contact bengr
mmenke: chrome/browser/profiles/*
6 years, 2 months ago (2014-10-08 18:22:11 UTC) #2
mmenke
LGTM https://codereview.chromium.org/643443002/diff/20001/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/643443002/diff/20001/chrome/browser/profiles/profile_impl_io_data.cc#newcode118 chrome/browser/profiles/profile_impl_io_data.cc:118: io_data_->data_reduction_proxy_enabled()->Destroy(); Think it's more consistent to do this ...
6 years, 2 months ago (2014-10-09 14:49:35 UTC) #3
Not at Google. Contact bengr
https://codereview.chromium.org/643443002/diff/20001/chrome/browser/profiles/profile_impl_io_data.cc File chrome/browser/profiles/profile_impl_io_data.cc (right): https://codereview.chromium.org/643443002/diff/20001/chrome/browser/profiles/profile_impl_io_data.cc#newcode118 chrome/browser/profiles/profile_impl_io_data.cc:118: io_data_->data_reduction_proxy_enabled()->Destroy(); On 2014/10/09 14:49:35, mmenke wrote: > Think it's ...
6 years, 2 months ago (2014-10-09 22:24:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/643443002/50001
6 years, 2 months ago (2014-10-10 00:00:14 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:50001)
6 years, 2 months ago (2014-10-10 00:17:11 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-10 00:18:15 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/08371872bc74c3ecfee9115551adb1e66fa5532d
Cr-Commit-Position: refs/heads/master@{#299020}

Powered by Google App Engine
This is Rietveld 408576698